Fixed #93 -- All empty REMOTE_ADDR values should set ip_address to null

@@ -106,7 +106,7 @@ def post_comment(request, next=None, using=None):
 
 
     # Otherwise create the comment
     # Otherwise create the comment
     comment = form.get_comment_object(site_id=get_current_site(request).id)
     comment = form.get_comment_object(site_id=get_current_site(request).id)
-    comment.ip_address = request.META.get("REMOTE_ADDR", None)
+    comment.ip_address = request.META.get("REMOTE_ADDR", None) or None
     if user_is_authenticated:
     if user_is_authenticated:
         comment.user = request.user
         comment.user = request.user
 
 

@@ -140,6 +140,15 @@ class CommentViewTests(CommentTestCase):
         self.assertEqual(c.ip_address, address)
         self.assertEqual(c.ip_address, address)
         self.assertEqual(c.comment, "This is my comment")
         self.assertEqual(c.comment, "This is my comment")
 
 
+    def testCreateValidCommentNoIP(self):
+        """Empty REMOTE_ADDR value should always set a null ip_address value."""
+        a = Article.objects.get(pk=1)
+        data = self.getValidData(a)
+        for address in ('', None, b''):
+            self.client.post("/post/", data, REMOTE_ADDR=address)
+            c = Comment.objects.last()
+            self.assertEqual(c.ip_address, None)
+
     def testCreateValidCommentIPv6Unpack(self):
     def testCreateValidCommentIPv6Unpack(self):
         address = "::ffff:18.52.18.52"
         address = "::ffff:18.52.18.52"
         a = Article.objects.get(pk=1)
         a = Article.objects.get(pk=1)