Commit a38859460ce1bd9e36f2863cf624f5609b2b20e9

Authored by Claude Paroz
1 parent 9b445f26

Updated assertRedirects compatibility wrapper

@@ -94,11 +94,9 @@ class CommentTestCase(TestCase): @@ -94,11 +94,9 @@ class CommentTestCase(TestCase):
94 94
95 def assertRedirects(self, response, expected_url, **kwargs): 95 def assertRedirects(self, response, expected_url, **kwargs):
96 """ 96 """
97 - Wrapper for assertRedirects to handle Django pre-1.7. 97 + Wrapper for assertRedirects to handle Django pre-1.9.
98 """ 98 """
99 - if VERSION >= (1, 7):  
100 - kwargs['fetch_redirect_response'] = False  
101 - return super(CommentTestCase, self).assertRedirects(  
102 - response, expected_url, **kwargs)  
103 - else:  
104 - self.assertEqual(response["Location"], expected_url) 99 + if VERSION >= (1, 9) and expected_url.startswith('http://testserver'):
  100 + expected_url = expected_url[len('http://testserver'):]
  101 + return super(CommentTestCase, self).assertRedirects(
  102 + response, expected_url, **kwargs)
@@ -41,7 +41,7 @@ class FlagViewTests(CommentTestCase): @@ -41,7 +41,7 @@ class FlagViewTests(CommentTestCase):
41 self.client.login(username="normaluser", password="normaluser") 41 self.client.login(username="normaluser", password="normaluser")
42 response = self.client.post("/flag/%d/" % pk, {'next': "/go/here/"}) 42 response = self.client.post("/flag/%d/" % pk, {'next': "/go/here/"})
43 self.assertRedirects(response, 43 self.assertRedirects(response,
44 - "http://testserver/go/here/?c=%d" % pk) 44 + "http://testserver/go/here/?c=%d" % pk, fetch_redirect_response=False)
45 45
46 def testFlagPostUnsafeNext(self): 46 def testFlagPostUnsafeNext(self):
47 """ 47 """
@@ -68,9 +68,13 @@ class FlagViewTests(CommentTestCase): @@ -68,9 +68,13 @@ class FlagViewTests(CommentTestCase):
68 comments = self.createSomeComments() 68 comments = self.createSomeComments()
69 pk = comments[0].pk 69 pk = comments[0].pk
70 response = self.client.get("/flag/%d/" % pk) 70 response = self.client.get("/flag/%d/" % pk)
71 - self.assertRedirects(response, "http://testserver/accounts/login/?next=/flag/%d/" % pk) 71 + self.assertRedirects(response,
  72 + "http://testserver/accounts/login/?next=/flag/%d/" % pk,
  73 + fetch_redirect_response=False)
72 response = self.client.post("/flag/%d/" % pk) 74 response = self.client.post("/flag/%d/" % pk)
73 - self.assertRedirects(response, "http://testserver/accounts/login/?next=/flag/%d/" % pk) 75 + self.assertRedirects(response,
  76 + "http://testserver/accounts/login/?next=/flag/%d/" % pk,
  77 + fetch_redirect_response=False)
74 78
75 def testFlaggedView(self): 79 def testFlaggedView(self):
76 comments = self.createSomeComments() 80 comments = self.createSomeComments()
@@ -113,7 +117,9 @@ class DeleteViewTests(CommentTestCase): @@ -113,7 +117,9 @@ class DeleteViewTests(CommentTestCase):
113 pk = comments[0].pk 117 pk = comments[0].pk
114 self.client.login(username="normaluser", password="normaluser") 118 self.client.login(username="normaluser", password="normaluser")
115 response = self.client.get("/delete/%d/" % pk) 119 response = self.client.get("/delete/%d/" % pk)
116 - self.assertRedirects(response, "http://testserver/accounts/login/?next=/delete/%d/" % pk) 120 + self.assertRedirects(response,
  121 + "http://testserver/accounts/login/?next=/delete/%d/" % pk,
  122 + fetch_redirect_response=False)
117 123
118 makeModerator("normaluser") 124 makeModerator("normaluser")
119 response = self.client.get("/delete/%d/" % pk) 125 response = self.client.get("/delete/%d/" % pk)
@@ -142,7 +148,7 @@ class DeleteViewTests(CommentTestCase): @@ -142,7 +148,7 @@ class DeleteViewTests(CommentTestCase):
142 self.client.login(username="normaluser", password="normaluser") 148 self.client.login(username="normaluser", password="normaluser")
143 response = self.client.post("/delete/%d/" % pk, {'next': "/go/here/"}) 149 response = self.client.post("/delete/%d/" % pk, {'next': "/go/here/"})
144 self.assertRedirects(response, 150 self.assertRedirects(response,
145 - "http://testserver/go/here/?c=%d" % pk) 151 + "http://testserver/go/here/?c=%d" % pk, fetch_redirect_response=False)
146 152
147 def testDeletePostUnsafeNext(self): 153 def testDeletePostUnsafeNext(self):
148 """ 154 """
@@ -187,7 +193,11 @@ class ApproveViewTests(CommentTestCase): @@ -187,7 +193,11 @@ class ApproveViewTests(CommentTestCase):
187 pk = comments[0].pk 193 pk = comments[0].pk
188 self.client.login(username="normaluser", password="normaluser") 194 self.client.login(username="normaluser", password="normaluser")
189 response = self.client.get("/approve/%d/" % pk) 195 response = self.client.get("/approve/%d/" % pk)
190 - self.assertRedirects(response, "http://testserver/accounts/login/?next=/approve/%d/" % pk) 196 + self.assertRedirects(
  197 + response,
  198 + "http://testserver/accounts/login/?next=/approve/%d/" % pk,
  199 + fetch_redirect_response=False
  200 + )
191 201
192 makeModerator("normaluser") 202 makeModerator("normaluser")
193 response = self.client.get("/approve/%d/" % pk) 203 response = self.client.get("/approve/%d/" % pk)
@@ -221,7 +231,8 @@ class ApproveViewTests(CommentTestCase): @@ -221,7 +231,8 @@ class ApproveViewTests(CommentTestCase):
221 response = self.client.post("/approve/%d/" % c1.pk, 231 response = self.client.post("/approve/%d/" % c1.pk,
222 {'next': "/go/here/"}) 232 {'next': "/go/here/"})
223 self.assertRedirects(response, 233 self.assertRedirects(response,
224 - "http://testserver/go/here/?c=%d" % c1.pk) 234 + "http://testserver/go/here/?c=%d" % c1.pk,
  235 + fetch_redirect_response=False)
225 236
226 def testApprovePostUnsafeNext(self): 237 def testApprovePostUnsafeNext(self):
227 """ 238 """
Please register or login to post a comment